Add helm chart prom-rds-exporter #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can we define cross-account role for RDS-Exporter..? Is it supportable? |
I only have one account so I've never tried this. You can try it with cross-account role. In theory, the role for the exporter only needs to ensure the policies as in the README I wrote. |
tplavcic
previously approved these changes
Feb 1, 2024
egegunes
reviewed
Feb 1, 2024
| # hosts: | ||
| # - chart-example.local | ||
|
|
||
| securityContext: |
There was a problem hiding this comment.
securityContext is duplicated
There was a problem hiding this comment.
Hi @egegunes
Thanks for comment. I've updated the chart and also check helm lint from my locally. Please verify again. Thanks.
dungpham91
requested review from
hors,
nmarukovich and
ptankov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
If you guys can take few mins to review and approve it. I think it's will be more convenience for the other guys when using it.
Thanks.
PS: my old PR percona/rds_exporter#89